Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use wt% and vol% for mixtures instead of %wt and %vol #65

Merged
merged 3 commits into from
Feb 13, 2024

Conversation

pkienzle
Copy link
Collaborator

Use the standard terminology for mixtures. The old %wt/%vol forms are still accepted, but they are not documented and will be removed if they cause any ambiguities in the formula grammar.

Copy link
Collaborator

@krzywon krzywon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and now both %(wt|mass|vol) and (wt|mass|vol)% are treated equivalently.

Code and documentation look good.

@pkienzle pkienzle merged commit 1b63ee5 into master Feb 13, 2024
4 checks passed
@pkienzle pkienzle deleted the fix-allow-wtvol-percent branch February 13, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants