Skip to content

Commit fd104ad

Browse files
author
ChasingImpact
committed
lint/types: utilities.py noqa+comma; stream.py coerce memoryview -> bytes; silence settings.py PLW1641
1 parent 222d39a commit fd104ad

File tree

3 files changed

+7
-6
lines changed

3 files changed

+7
-6
lines changed

src/h2/settings.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ def __repr__(self) -> str:
9090
)
9191

9292

93-
class Settings(MutableMapping[Union[SettingCodes, int], int]):
93+
class Settings(MutableMapping[Union[SettingCodes, int], int]): # noqa: PLW1641
9494
"""
9595
An object that encapsulates HTTP/2 settings state.
9696

src/h2/stream.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -968,7 +968,7 @@ def send_data(self,
968968
self.state_machine.process_input(StreamInputs.SEND_DATA)
969969

970970
df = DataFrame(self.stream_id)
971-
df.data = data
971+
df.data = data.tobytes() if isinstance(data, memoryview) else data
972972
if end_stream:
973973
self.state_machine.process_input(StreamInputs.SEND_END_STREAM)
974974
df.flags.add("END_STREAM")

src/h2/utilities.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -361,9 +361,11 @@ def _reject_pseudo_header_fields(headers: Iterable[Header],
361361
)
362362

363363

364-
def _check_pseudo_header_field_acceptability(pseudo_headers: set[bytes | str] | set[bytes] | set[str],
365-
method: bytes | None,
366-
hdr_validation_flags: HeaderValidationFlags) -> None:
364+
def _check_pseudo_header_field_acceptability( # noqa: C901
365+
pseudo_headers: set[bytes | str] | set[bytes] | set[str],
366+
method: bytes | None,
367+
hdr_validation_flags: HeaderValidationFlags,
368+
) -> None:
367369
"""
368370
Given the set of pseudo-headers present in a header block and the
369371
validation flags, confirms that RFC 7540 allows them.
@@ -385,7 +387,6 @@ def _check_pseudo_header_field_acceptability(pseudo_headers: set[bytes | str] |
385387
if invalid_response_headers:
386388
msg = f"Encountered request-only headers {invalid_response_headers}"
387389
raise ProtocolError(msg)
388-
389390
elif (not hdr_validation_flags.is_response_header and
390391
not hdr_validation_flags.is_trailer):
391392
# Request header block.

0 commit comments

Comments
 (0)