Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cloudpickle supports Python 3.14 already #1397

Closed
frenzymadness opened this issue Jan 27, 2025 · 0 comments · Fixed by #1398
Closed

Cloudpickle supports Python 3.14 already #1397

frenzymadness opened this issue Jan 27, 2025 · 0 comments · Fixed by #1398

Comments

@frenzymadness
Copy link
Contributor

I think the xfail marker here is not needed anymore:

attrs/tests/test_3rd_party.py

Lines 19 to 21 in fbff14e

@pytest.mark.xfail(
PY_3_14_PLUS, reason="cloudpickle is currently broken on 3.14."
)

as the latest release of cloudpickle is compatible with Python 3.14. See cloudpipe/cloudpickle@7468d72 and https://github.com/cloudpipe/cloudpickle/blob/master/CHANGES.md#311
frenzymadness added a commit to frenzymadness/attrs that referenced this issue Jan 27, 2025
@frenzymadness
Don't expect TestCloudpickleCompat to fail with Python 3.14
010e6b9 
Cloudpickle supports Python 3.14 already.

Fixes: python-attrs#1397
@frenzymadness frenzymadness mentioned this issue Jan 27, 2025
Merged
github-merge-queue bot pushed a commit that referenced this issue Jan 27, 2025
@frenzymadness
Don't expect TestCloudpickleCompat to fail with Python 3.14 (#1398)
eb49c53 
Cloudpickle supports Python 3.14 already.

Fixes: #1397
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't expect TestCloudpickleCompat to fail with Python 3.14 frenzymadness/attrs
1 participant
@frenzymadness