Don't correctly parse contain @ ssh password

[SouthFox-D]

version: testinfra-10.0.0

pytest --hosts=ssh://root:foo@bar@192.168.100.1 test.py -vvv

Captured log:

DEBUG testinfra:base.py:328 RUN CommandResult(backend=<testinfra.backend.ssh.SshBackend object at 0x7f1514287490>, exit_status=5, command=b"sshpass -p foo ssh -o User=root -o ConnectTimeout=10 -o ControlMaster=auto -o ControlPersist=60s bar@192.168.100.1 'uname -s'", _stdout=b'', _stderr=b'Permission denied, please try again.\r\n')

[philpep]

Did you try to urlencode the password ? e.g.:

pytest --hosts 'ssh://root:foo%40bar@192.168.100.1' test.py -vvv

[SouthFox-D]

Did you try to urlencode the password ? e.g.:

pytest --hosts 'ssh://root:foo%40bar@192.168.100.1' test.py -vvv

Thanks, it works, and it works in ansible as well.

But I'm handling passwords via environment variables, so I can't use urlencode anywhere (unless maintained separately).

Is it a good idea to use rspilt instead of spilt for parse_hostspec?

pytest-testinfra/testinfra/backend/base.py

Lines 241 to 247 in dc48cd9

	def parse_hostspec(hostspec: str) -> HostSpec:
	name = hostspec
	port = None
	user = None
	password = None
	if "@" in name:
	user, name = name.split("@", 1)

        if "@" in name:
            user, name = name.rsplit("@", 1)

[CarstenGrohmann]

With rsplit(), colons are possible in the password without encoding, but not in the user name.

Since there is no general solution, I suggest to leave the code as it is and to extend the documentation with #783.