Skip to content

Commit

Permalink
Bump required pytest version to 4.6
Browse files Browse the repository at this point in the history
We have started getting an error with pytest>=4,<4.6 when setuptools>=71
(or typeguard>=4.2) is also installed, due to a conflict with older
pytest and setuptools' vendored version of typeguard. Out of various
ways to resolve this conflict, this is the only one that doesn't involve
putting an upper bound on the version of some package.

It should still be technically possible to use older versions of pytest
along with setuptools<71, if someone really needs to do that, but there
isn't any way to express that dependency constraint, and I'm not going
to go to any trouble to support long-obsolete versions of packages.
  • Loading branch information
diazona committed Oct 5, 2024
1 parent 5ef5c77 commit caa00d6
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
10 changes: 5 additions & 5 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,19 +19,19 @@ jobs:
python-version: ['3.7', '3.8', '3.9', '3.10', '3.11', '3.12', '3.13', 'pypy-3.7', 'pypy-3.8', 'pypy-3.9']
extra: ['', '-smtp']
# The forced pytest versions correspond with the lower bounds in tox.ini
pytest-version: ['', '--force-dep pytest==4', '--force-dep pytest==6.2.4']
pytest-version: ['', '--force-dep pytest==4.6', '--force-dep pytest==6.2.4']
include:
- os: 'ubuntu-20.04'
python-version: '3.6'
exclude:
- python-version: '3.10'
pytest-version: '--force-dep pytest==4'
pytest-version: '--force-dep pytest==4.6'
- python-version: '3.11'
pytest-version: '--force-dep pytest==4'
pytest-version: '--force-dep pytest==4.6'
- python-version: '3.12'
pytest-version: '--force-dep pytest==4'
pytest-version: '--force-dep pytest==4.6'
- python-version: '3.13'
pytest-version: '--force-dep pytest==4'
pytest-version: '--force-dep pytest==4.6'
fail-fast: false

steps:
Expand Down
2 changes: 1 addition & 1 deletion tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ deps =
# works with your code. Don't forget to modify the corresponding entries in
# the Github workflows configuration file if you do change these lower
# bounds.
pytest >=4, <8; python_version<'3.10'
pytest >=4.6, <8; python_version<'3.10'
pytest >=6.2.4, <8; python_version>='3.10'
pytest-cov
requests
Expand Down

0 comments on commit caa00d6

Please sign in to comment.