Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in Readme.md #2

Open
melston opened this issue Mar 11, 2018 · 4 comments
Open

Error in Readme.md #2

melston opened this issue Mar 11, 2018 · 4 comments

Comments

@melston
Copy link

melston commented Mar 11, 2018

In the description of how to run a single test you have

    gradle :fpinkotlin-advancedlisthandling-exercises:test --tests com.fpinkotlin.advancedlisthandling.exercise01.ListTest

However, when I run this command without making any modifications to the projects (don't implement the required functionality) I don't get an error. Apparently, this is because the given test doesn't exist. If, instead, I run:

    gradle :fpinkotlin-advancedlisthandling-exercises:test --tests com.fpinkotlin.advancedlisthandling.exercise02.ListTest

I do, indeed, see an error (note the use of exercise02 instead of exercise01).

@pysaumont
Copy link
Owner

Hi Mark,

Thank you for spotting this error. The test in the exercise module was using the wrong function (length instead of lengthMemoized. This is now fixed.

@melston
Copy link
Author

melston commented Mar 12, 2018

Thanks, it now works as expected.

BTW, I am a TDE on the book. It is good to be working with you again. I learned a lot on FP in Java. It was sometimes frustratingly difficult but always worth the effort. I have recommended it to a colleague and he is working his way through it as well.

Something to be aware of is that something is now broken in the latest IntelliJ versions. For some reason the gradle integration has been broken so it is now unusable. See this issue. Gradle still works from the command-line, though it has to be the installed gradle and not the gradlew.bat file for some reason.

@pysaumont
Copy link
Owner

Good to be working with you again! I had no problem with IntelliJ/Gradle until now, but I don't use the EAP versions.

@melston
Copy link
Author

melston commented Mar 13, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants