Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate the exhaustion time in the Alerts #788

Closed
achetronic opened this issue Jun 20, 2023 · 5 comments
Closed

Populate the exhaustion time in the Alerts #788

achetronic opened this issue Jun 20, 2023 · 5 comments

Comments

@achetronic
Copy link
Contributor

Hello there @metalmatze,

I have seen that the alerts to Alertmanager are not having a description, or a summary. It can be interesting to have deeper data for them just to bring more light to the devs that rely on that information to hurry when the error budget is burning.

IMHO, an interesting approach is populating the exhaustion time for crafting a meaningful message with it, because depending on it, more developers can focus on the problem.

Proposed code is implemented in this PR

@JoSeF267
Copy link

hello! i just need these changes too. I think they are necessary to improve the alerts and give a better support. when could it be ready? thanks!

@dr-tomasz
Copy link

This is exactly what I need! Hope it will pass 🙏 🚀

@jkrol2
Copy link

jkrol2 commented Jun 21, 2023

+1 👍

@achetronic
Copy link
Contributor Author

Hey @metalmatze 😄 invoking some maintainer here 🙏🏼

@achetronic
Copy link
Contributor Author

Closing the issue as merged here: #787

Thank you @metalmatze fr reviewing it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants