Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Month view "datasetName" doesn't function as a title when "mode: annotation" is set #298

Open
JulianVJacobs opened this issue Jan 15, 2024 · 5 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@JulianVJacobs
Copy link

When I set "mode: annotation" for the month view, the datasetName no longer functions as the title

Expected Behavior

Obviously I expect that the datasetName should act as it usually does when the annotation mode isn't enabled. That is, I expect it to function as the title. Otherwise, perhaps month should have a title property.

Current Behavior

The datasetName disappears when mode: annotation is set

Steps to Reproduce (for bugs)

Set a month view and set mode: annotation to be true.

Context

@lazyguru lazyguru added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Jan 15, 2024
@lazyguru
Copy link
Collaborator

Adding some screenshot examples from me reproducing so whoever picks this up can understand:

mode: annotation
Screenshot 2024-01-15 at 12 13 59 AM

without mode set
Screenshot 2024-01-15 at 12 14 24 AM

Ideally we should be able to still display the name when mode: annotation is set.

My dataview setup (not necessarily the same as ops, but it reproduces):

searchType: frontmatter
searchTarget: Reading
folder: Journal/Daily
datasetName: Reading
month:
	mode: annotation
	annotation: 📖
	startWeekOn: 'Mon'
	color: steelBlue	

Example entry:

---
Reading: true
---

@lazyguru
Copy link
Collaborator

When I was testing for the 1.13.2 release (just released today), the example files were working correctly. Can you please upgrade and recheck?

@akshayats
Copy link

I have the same problem.

Case 1:

```tracker
searchType: frontmatter
searchTarget: exercise
folder: "habits"
datasetName: Shambhavi
fixedScale: 1.3
month:
	mode: annotation
	annotation: 🧘‍♂️
	startWeekOn: 'Mon'
	color: steelblue
```

image


Case 2:

```tracker
searchType: frontmatter
searchTarget: exercise
folder: "habits"
datasetName: Shambhavi
fixedScale: 1.3
month:
        startWeekOn: 'Mon'
	color: steelblue
```

image

@stockphrase
Copy link

Just wanted to add I have the same issue with 1.14.0

@tuliogd
Copy link

tuliogd commented Jul 15, 2024

Same here with 1.14.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants