Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for TruncatedDistribution #895

Closed
fehiepsi opened this issue Jan 26, 2021 · 1 comment · Fixed by #915
Closed

Support for TruncatedDistribution #895

fehiepsi opened this issue Jan 26, 2021 · 1 comment · Fixed by #915
Labels
enhancement New feature or request

Comments

@fehiepsi
Copy link
Member

Currently, we have one-side truncated normal and cauchy implemented. But it would be nice to add a general class, which uses cdf method, for other distributions. There is a nice discussion here for context on relevant numerical issues.

cc @fritzo

@fehiepsi fehiepsi added the enhancement New feature or request label Jan 26, 2021
@fritzo
Copy link
Member

fritzo commented Jan 26, 2021

Note we also have the one-sided general FoldedDistribution in Pyro, which is a cheap rsample-friendly qualitatively similar alternative to TruncatedDistribution. This doesn't get us any closer to literally translating Stan models, but maybe we can take license to approximately translate models and e.g. check that we're only slightly truncating, or not truncating past the median (since Folded and Truncated differ for severely truncated distributions).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants