warehouse/accounts/services.py

@@ -983,28 +983,28 @@ def get_domain_status(self, _domain: str) -> list[str]:
 
 @implementer(IDomainStatusService)
 class DomainrDomainStatusService:
-    def __init__(self, session, api_key):
+    def __init__(self, session, client_id):
         self._http = session
-        self.api_key = api_key
+        self.client_id = client_id
 
     @classmethod
     def create_service(cls, _context, request: Request) -> DomainrDomainStatusService:
-        domainr_api_key = request.registry.settings.get("domainr.api_key")
-        return cls(session=request.http, api_key=domainr_api_key)
+        domainr_client_id = request.registry.settings.get("domainr.client_id")
+        return cls(session=request.http, client_id=domainr_client_id)
 
     def get_domain_status(self, domain: str) -> list[str]:
         """
         Check if a domain is available or not.
         See https://domainr.com/docs/api/v2/status
         """
-        # bail early if no api key is set, so we don't send failing requests
-        if not self.api_key:
-            return []
+        # bail early if no client ID is set, so we don't send failing requests
+        if not self.client_id:
+            raise RuntimeError("Domainr client ID not set")
 
         try:
             resp = self._http.get(
                 "https://api.domainr.com/v2/status",
-                params={"client_id": self.api_key, "domain": domain},
+                params={"client_id": self.client_id, "domain": domain},
                 timeout=5,
             )
             resp.raise_for_status()