Skip to content

Commit 953269d

Browse files
committed
Use a less sloppy check in remove_avoided_requirements
Resolves pyodide/pyodide#5187. In that issue, the build requires a package called `cmake-build-extension` but because we have `cmake` in the list of requirements to avoid we drop it and it breaks the build. This logic was introduced in pyodide/pyodide#2272 and did not come up in the review. Surprisingly this is the first problem it has caused. Let's see if this change breaks anything in Pyodide CI.
1 parent fac0109 commit 953269d

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

pyodide_build/pypabuild.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ def remove_avoided_requirements(
118118
for reqstr in list(requires):
119119
req = Requirement(reqstr)
120120
for avoid_name in set(avoided_requirements):
121-
if avoid_name in req.name.lower():
121+
if avoid_name == req.name.lower():
122122
requires.remove(reqstr)
123123
return requires
124124

0 commit comments

Comments
 (0)