-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TODO: Clarify coordinate systems #173
Comments
I spent a bit more time on the useq plate code. As a starting point I think it is easier to define the coordinate system we want and always use the same. Then maybe we can find a way to let the users set the system they want to use. We are already using a cartesian coordinate system where -x is left, +x is right, -y is down and +y is up in the ![]() So I think it can be a good idea to keep the same coordinate system also for the This approach also makes it easy to plot and visualize the position. If we decide to keep the coordinate system constant, then it does not matter what is the coordinate system of the microscope stage because it will be up to the user to invert the coordinate if necessary (I did few test in the past with Nikon stages and Prior stages and they use different coordinate systems, so it is hard to generalize). In this PR #175 I updated the code so that we use the cartesian coordinate system where -x is left, +x is right, -y is down and +y is up. We only need to apply the transformation once and we do not even need to invert any coordinates when we use the plot function. ![]() |
sounds good, thanks for clarifying! we should put something like this somewhere in the docs. can be very brief. don't need to do it now |
For reference, MMStudio's stated convention has the Y axis flipped: https://micro-manager.org/Coordinates_and_Directionality, first paragraph (note that some of what is written there might be aspirational). There are probably arguments for either way, but it might be worth noting this when writing the docs. |
Thanks @marktsuchida! |
i'm generally observing that coordinate systems are indeed a sticky point, that I'm still a little bit confused about exactly when and where these coordinate systems need to be declared, what they depend on (is it the stage? is it the plotting system? is it some transformation system? all of the above? etc...). And if I'm a bit confused, then I'm certain that the average user would probably be a bit confused...
And so I'd like to see it all given a more formal treatment, some documentation somewhere that
once I understand the above a bit better, i think the answer to this question will probably be more obvious.
Originally posted by @tlambert03 in #172 (comment)
The text was updated successfully, but these errors were encountered: