Skip to content

Remove uses of numba_basic.global_numba_func(erfc)  #1442

Open
@ricardoV94

Description

@ricardoV94

Description

@numba_basic.numba_njit
def erfc(x):
return math.erfc(x)
@numba_funcify.register(Erfc)
def numba_funcify_Erfc(op, **kwargs):
return numba_basic.global_numba_func(erfc)

This was used to try and improve caching of numba functions, but when investigating it, it doesn't seem necessary. Numba is happy to cache the usual way we dispatch functions, with limitations lying elsewhere. Removing the "hack", should make the code a bit tidier.

@numba_funcify.register(Erfc) 
def numba_funcify_Erfc(op, **kwargs): 

    @numba_basic.numba_njit
    def erfc(x)
        return math.erfc(x)

This is used in more places

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions