Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase tolerance in TestGARCH11::test_batched_size to reduce flakiness #7684

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JigyasuRajput
Copy link

@JigyasuRajput JigyasuRajput commented Feb 18, 2025

Description

Increased the absolute (atol=1e-3) and relative (rtol=1e-2) tolerances in np.testing.assert_allclose within TestGARCH11::test_batched_size.
This should help reduce test flakiness caused by minor numerical variations.

Related Issue

Checklist

  • Checked that the pre-commit linting/style checks pass
  • Included tests that prove the fix is effective or that the new feature works (ran pytest tests/distributions/test_timeseries.py)
  • Added necessary documentation (docstrings and/or example notebooks)
  • If you are a pro: each commit corresponds to a relevant logical change

Type of change

  • Bug fix
  • New feature / enhancement
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc--7684.org.readthedocs.build/en/7684/

Copy link

welcome bot commented Feb 18, 2025

Thank You Banner]
💖 Thanks for opening this pull request! 💖 The PyMC community really appreciates your time and effort to contribute to the project. Please make sure you have read our Contributing Guidelines and filled in our pull request template to the best of your ability.

@github-actions github-actions bot added the tests label Feb 18, 2025
@ricardoV94
Copy link
Member

Hmm looks like that test should be deterministic, so the failures may indicate an underlying bug. Can you check if the results come different in different runs of the test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky tests/distributions/test_timeseries.py::TestGARCH11::test_batched_size
2 participants