You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have reviewed your work and have some suggestions for improvement. I would say that String can replace Unbounded_String in just about all cases.
Use Ada.Containers.Indefinite_Vectors/Ordered_Maps/Holders instantiated with String instead of Unbounded_String vectors and maps.
Introduce types for vector Index_Type like Line_Number etc instead of Positive.
subtype String_Vector is String_Vectors.Vector etc just after container instantiation. This will make the code shorter and lighter.
Use String parameters instead of Unbounded_String.
Add typing with types or/and subtypes like Directory_Name / File_Name / Program_Line from String.
Use subtype nearly like an alias of common datatypes in packages using them. Ie subtype String_Vector is SP.Strings.String_Vectors.Vector in packages using a lot of String_Vectors.Vector.
I hope the suggestions can be used. Exited to get a macOS version soon..;-)
The text was updated successfully, but these errors were encountered:
I have reviewed your work and have some suggestions for improvement. I would say that
String
can replaceUnbounded_String
in just about all cases.Ada.Containers.Indefinite_Vectors/Ordered_Maps/Holders
instantiated withString
instead ofUnbounded_String
vectors and maps.Index_Type
likeLine_Number
etc instead ofPositive
.subtype String_Vector is String_Vectors.Vector
etc just after container instantiation. This will make the code shorter and lighter.String
parameters instead ofUnbounded_String
.Directory_Name
/File_Name
/Program_Line
fromString
.subtype String_Vector is SP.Strings.String_Vectors.Vector
in packages using a lot ofString_Vectors.Vector
.I hope the suggestions can be used. Exited to get a macOS version soon..;-)
The text was updated successfully, but these errors were encountered: