Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

datatree: Implement in-place binary ops #9629

Open
TomNicholas opened this issue Oct 15, 2024 · 0 comments
Open

datatree: Implement in-place binary ops #9629

TomNicholas opened this issue Oct 15, 2024 · 0 comments
Labels
enhancement topic-DataTree Related to the implementation of a DataTree class

Comments

@TomNicholas
Copy link
Member

TomNicholas commented Oct 15, 2024 •
edited
Loading

I suspect this actually needs a different implementation, in order to handle error recovery properly.

I would suggest handling this like Dataset._inplace_binary_op, which builds result Dataset and then replaces the contents of the current dataset with those of the new dataset.

Originally posted by @shoyer in #9619 (comment)
@TomNicholas TomNicholas added topic-DataTree Related to the implementation of a DataTree class enhancement labels Oct 15, 2024
@TomNicholas TomNicholas mentioned this issue Oct 15, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement topic-DataTree Related to the implementation of a DataTree class
Projects
DataTree integration
Status: To do
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TomNicholas