From 7f99f9eaa062e81e0d36428cfe80e2ad7d24442d Mon Sep 17 00:00:00 2001 From: Maximilian Roos <5635139+max-sixty@users.noreply.github.com> Date: Tue, 30 Apr 2024 12:46:34 -0700 Subject: [PATCH] Skip flaky `test_open_mfdataset_manyfiles` test (#8989) * Skip flaky `test_open_mfdataset_manyfiles` test Don't just xfail, and not only on windows, since it can crash the worked * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> --- xarray/tests/test_backends.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/xarray/tests/test_backends.py b/xarray/tests/test_backends.py index fdf181b583a..8564191a0f7 100644 --- a/xarray/tests/test_backends.py +++ b/xarray/tests/test_backends.py @@ -3813,11 +3813,11 @@ def skip_if_not_engine(engine): pytest.importorskip(engine) -# Flaky test. Very open to contributions on fixing this @requires_dask @pytest.mark.filterwarnings("ignore:use make_scale(name) instead") -@pytest.mark.xfail(reason="Flaky test. Very open to contributions on fixing this") -@pytest.mark.skipif(ON_WINDOWS, reason="Skipping on Windows") +@pytest.mark.skip( + reason="Flaky test which can cause the worker to crash (so don't xfail). Very open to contributions fixing this" +) def test_open_mfdataset_manyfiles( readengine, nfiles, parallel, chunks, file_cache_maxsize ):