Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back to top button colors #1925

Open
OriolAbril opened this issue Jul 11, 2024 · 1 comment · May be fixed by #1927
Open

Back to top button colors #1925

OriolAbril opened this issue Jul 11, 2024 · 1 comment · May be fixed by #1927
Labels
kind: bug Something isn't working

Comments

@OriolAbril
Copy link
Contributor

I noticed that the hover color for the "back to top" button is hardcoded to violet, so changing --pst-color-secondary results in strange/unexpected behaviour where the button goes from the custom color to violet on hover. I checked the behaviour when no colors are changed and I noticed the hover has a darkening effect between two shades of violet. I also noticed the --pst-color-secondary-highlight that is defined when using sphinx-design which would give nearly the same effect (and work for any --pst-secondary-color).

Would it be ok to include the ...-highlight colors as part of the theme and use that for the hover effect in "back to top" button?

@trallard
Copy link
Collaborator

trallard commented Jul 12, 2024

Thanks for opening this issue, @OriolAbril. This was hardcoded while completing the design system work, and we forgot to revisit it.

I will update the button colour.

Would it be ok to include the ...-highlight colors as part of the theme and use that for the hover effect in "back to top" button?

These should be included in the same way that --pst-color-xyz are included, for example if I inspect the PyData documentation I can see these in the developer tools

--pst-color-secondary-text: #14181e;
--pst-color-secondary-highlight: #6d13fc;
--sd-color-secondary-highlight: var(--pst-color-secondary-highlight);

so I am assuming you are asking for these to be customisable as described in https://pydata-sphinx-theme.readthedocs.io/en/stable/user_guide/styling.html ?

I will push a fix soon so this is doable

@trallard trallard added the kind: bug Something isn't working label Jul 12, 2024
@trallard trallard linked a pull request Jul 15, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants