Proposal review not working in admin. #57

lsilen · 2015-05-12T00:42:50Z

I'm trying to determine how the proposal review process works on the Seattle site and I can't get it to work in admin. I've opened it in the dashboard. I need to give access to the review committee tomorrow.

thanks,
leah

jeffsedik · 2015-05-12T15:39:48Z

@lsilen
Can you please provide a relevant link for this?

lsilen · 2015-05-12T16:02:09Z

http://seattle.pydata.org/reviews/section/general-sessions/all/

codersquid · 2015-05-12T16:03:48Z

For this, you need to create a team via the django admin, http://london.pydata.org/admin/teams/team/

I'm explaining this from memory so I may be wrong.

Make a team that you can provide a link to so that people can request to be in the team, or there may be a better option.

if you all can't get to this during today, I can try to follow up late this evening.

codersquid · 2015-05-12T16:04:06Z

You'll also need to add relevant permissions to the team.

lsilen · 2015-05-12T16:11:16Z

It looks like you create a group and add permissions, which I did. But I tried to review by clicking on +0 or +1 and I can't get the "vote" to register.

codersquid · 2015-05-12T16:17:18Z

did someone run the symposion django management command to generate the reviewer permissions? I think it happened? but my assumption should be verified.

Be careful, create a Team using the team admin, not a group using the django auth admin.

lsilen · 2015-05-12T16:18:26Z

I just gave your sheila @codersquid account access to the Review Group

lsilen · 2015-05-12T16:22:40Z

Oh, I created a group. Should I somehow undo, that. I see teams at the bottom.

jeffsedik · 2015-05-12T16:28:45Z

@codersquid - we didn't run the symposion django management command to generate the reviewer permissions. @danrjohnson isn't sure what that is. can you run it or provide instructions on what Dan should do?

codersquid · 2015-05-12T17:20:33Z

@danrjohnson it is the create_review_permissions management command.

Here's more info about setting up review permissions and teams
https://groups.google.com/d/msg/pinax-symposion/5dWWuPuqEjc/jZNcu4spzHMJ

codersquid · 2015-05-12T17:22:54Z

I can't run it. I do have an account on the box now, but it is prompting me to change my password, which I do not know.

danrjohnson · 2015-05-12T17:36:13Z

@codersquid I sent along a passwd to use. Forgot to send that earlier.

lsilen · 2015-05-12T23:11:25Z

Any updates on this?

Are we going to be able to use the review management?

-Leah

On May 12, 2015, at 12:36 PM, Dan Johnson [email protected] wrote:

@codersquid https://github.com/codersquid I sent along a passwd to use. Forgot to send that earlier.

—
Reply to this email directly or view it on GitHub #57 (comment).

Leah Silen
Executive Director
NumFOCUS http://numfocus.org/
[email protected]
512-222-5449

lsilen · 2015-05-13T14:35:10Z

I have a committee waiting to review proposals and need to know if they can do this using admin. I need to let them know this morning.

-Leah

jeffsedik · 2015-05-13T14:44:41Z

@lsilen
You should be able to use the review management but not yet. Dan will update this issue when he's clear.

lsilen · 2015-05-13T14:50:00Z

That’s great news. Thank you. Can I get an idea of when they can use it? I guess I can always copy and paste the proposals for them to began reading if necessary.

On May 13, 2015, at 9:44 AM, jeffsedik [email protected] wrote:

@lsilen https://github.com/lsilen
You should be able to use the review management but not yet. Dan will update this issue when he's clear.

—
Reply to this email directly or view it on GitHub #57 (comment).

Leah Silen
Executive Director
NumFOCUS http://numfocus.org/
[email protected]
512-222-5449

jeffsedik · 2015-05-13T14:56:07Z

@lsilen
It's on Dan's plate for today. Hopefully the issue will be resolved soon. Will keep the issue updated and let you and Shelia know if we run into any problems.

danrjohnson · 2015-05-13T15:50:20Z

@lsilen
I ran the management command and created a team for reviewers:
http://seattle.pydata.org/admin/teams/team/1/

I'm not sure if this should be by invitation or by application, so you may need to adjust this.

lsilen · 2015-05-13T15:56:58Z

Can I just give permissions to the users on the committee under their accounts?

On May 13, 2015, at 10:50 AM, Dan Johnson [email protected] wrote:

@lsilen https://github.com/lsilen
I ran the management command and created a team for reviewers:
http://seattle.pydata.org/admin/teams/team/1/ http://seattle.pydata.org/admin/teams/team/1/
I'm not sure if this should be by invitation or by application, so you may need to adjust this.

—
Reply to this email directly or view it on GitHub #57 (comment).

Leah Silen
Executive Director
NumFOCUS http://numfocus.org/
[email protected]
512-222-5449

danrjohnson · 2015-05-13T16:00:18Z

You can invite them via there email address here: http://seattle.pydata.org/teams/reviewers/

There is a way to create memberships via the django admin, but it will be difficult to isolate which account is which because of the random nature symposian creates usersnames. I believe this is the only way to do this, but I might be wrong. @codersquid Does that sound right?

lsilen · 2015-05-13T16:12:23Z

How do I get to that page (other than the link)?

On May 13, 2015, at 11:00 AM, Dan Johnson [email protected] wrote:

You can invite them via there email address here: http://seattle.pydata.org/teams/reviewers/ http://seattle.pydata.org/teams/reviewers/
There is a way to create memberships via the django admin, but it will be difficult to isolate which account is which because of the random nature symposian creates usersnames. I believe this is the only way to do this, but I might be wrong. @codersquid https://github.com/codersquid Does that sound right?

—
Reply to this email directly or view it on GitHub #57 (comment).

Leah Silen
Executive Director
NumFOCUS http://numfocus.org/
[email protected]
512-222-5449

lsilen · 2015-05-13T16:15:53Z

Dan, should I be able to rate them now on: http://seattle.pydata.org/reviews/section/general-sessions/all/?

codersquid · 2015-05-13T16:19:23Z

Yes, the username feature is an annoyance of symposion and there may even
be an open issue about it.

On Wed, May 13, 2015 at 11:00 AM, Dan Johnson [email protected]
wrote:

You can invite them via there email address here:
http://seattle.pydata.org/teams/reviewers/

There is a way to create memberships via the django admin, but it will be
difficult to isolate which account is which because of the random nature
symposian creates usersnames. I believe this is the only way to do this,
but I might be wrong. @codersquid https://github.com/codersquid Does
that sound right?

—
Reply to this email directly or view it on GitHub
#57 (comment).

[email protected]

codersquid · 2015-05-13T16:24:33Z

On Wed, May 13, 2015 at 11:12 AM, lsilen [email protected] wrote:

How do I get to that page (other than the link)?

It may show up on your dashboard, but I can't see the dashboard to verify
my memory.

Give the link to all of your reviewers so that they can apply to it to be
able to use the review dashboard.

[email protected]

codersquid · 2015-05-13T16:25:13Z

On Wed, May 13, 2015 at 11:15 AM, lsilen [email protected] wrote:

Dan, should I be able to rate them now on:
http://seattle.pydata.org/reviews/section/general-sessions/all/?

You should be able to.

[email protected]

lsilen · 2015-05-13T16:34:33Z

I'm getting an Internal Server error trying to open my account in the dashboard

danrjohnson · 2015-05-13T16:35:13Z

@lsilen I'm looking at this in #60

danrjohnson · 2015-05-13T16:43:07Z

Fixed via 3dda187

lsilen · 2015-05-14T14:42:26Z

[email protected]

On May 14, 2015, at 9:04 AM, jeffsedik [email protected] wrote:

@lsilen https://github.com/lsilen
Please supply the credentials for the new account you set up so we can take a look.

—
Reply to this email directly or view it on GitHub #57 (comment).

Leah Silen
Executive Director
NumFOCUS http://numfocus.org/
[email protected]
512-222-5449

jeffsedik · 2015-05-14T14:50:09Z

Password, too, please. Want to log in as that account and see what you're seeing.

lsilen · 2015-05-14T14:53:49Z

Here you go: data

On May 14, 2015, at 9:50 AM, jeffsedik [email protected] wrote:

Password, too, please. Want to log in as that account and see what you're seeing.

—
Reply to this email directly or view it on GitHub #57 (comment).

Leah Silen
Executive Director
NumFOCUS http://numfocus.org/
[email protected]
512-222-5449

lsilen · 2015-05-14T15:00:46Z

Can you get the reveiws to show up on your account? I can take a screenshot or share my screen on hangout.

jeffsedik · 2015-05-14T15:03:33Z

No need for a screenshot. Seeing the issue logged in with that account. @danrjohnson - please take a look at this. You can duplicate the issue by viewing http://seattle.pydata.org/teams/reviewers/ when you're logged in as [email protected] / data

lsilen · 2015-05-14T15:08:45Z

I couldn't get it to show up for my other "super user" account either. [email protected] numfocus

lsilen · 2015-05-14T16:13:59Z

I also need to give the London committee access to see their proposals. Should everything be working on that site?

jeffsedik · 2015-05-14T16:32:32Z

@lsilen - will verify that all the changes applied to Seattle regarding this issue have also been applied to the London site.

lsilen · 2015-05-14T16:56:37Z

Are we close to having Seattle working? I need Seattle working ASAP and London by the end of the day.
Thanks

danrjohnson · 2015-05-14T17:09:52Z

Getting an actual error inside symposian related to review process. Posting here.
ERROR Internal Server Error: /reviews/review/6/
Traceback (most recent call last):
File "/www/conf_site/env/local/lib/python2.7/site-packages/django/core/handlers/base.py", line 111, in get_response
response = wrapped_callback(request, _callback_args, *_callback_kwargs)
File "/www/conf_site/env/local/lib/python2.7/site-packages/django/contrib/auth/decorators.py", line 21, in _wrapped_view
return view_func(request, _args, *_kwargs)
File "/www/conf_site/env/local/lib/python2.7/site-packages/symposion/reviews/views.py", line 203, in review_detail
review.save()
File "/www/conf_site/env/local/lib/python2.7/site-packages/symposion/reviews/models.py", line 131, in save
self.proposal.result.update_vote(self.vote)
File "/www/conf_site/env/local/lib/python2.7/site-packages/symposion/reviews/models.py", line 280, in update_vote
model._default_manager.filter(pk=self.pk).update(score=ProposalScoreExpression())
File "/www/conf_site/env/local/lib/python2.7/site-packages/django/db/models/query.py", line 583, in update
rows = query.get_compiler(self.db).execute_sql(CURSOR)
File "/www/conf_site/env/local/lib/python2.7/site-packages/django/db/models/sql/compiler.py", line 1004, in execute_sql
cursor = super(SQLUpdateCompiler, self).execute_sql(result_type)
File "/www/conf_site/env/local/lib/python2.7/site-packages/django/db/models/sql/compiler.py", line 775, in execute_sql
sql, params = self.as_sql()
File "/www/conf_site/env/local/lib/python2.7/site-packages/django/db/models/sql/compiler.py", line 967, in as_sql
(field.class.name, val.class.name))
TypeError: Database is trying to update a relational field of type DecimalField with a value of type ProposalScoreExpression. Make sure you are setting the correct relations

codersquid · 2015-05-14T17:16:57Z

I found a post in the symposion mailing list about it, https://groups.google.com/d/msg/pinax-symposion/ryXLRpTiDns/6qPbQWhx5bsJ and there is no follow up there. I'll post a follow up and say we have the same problem.

danrjohnson · 2015-05-14T17:25:59Z

@codersquid I saw that issue and found a fork of symposion that addressed this issue.

https://github.com/euroscipy/symposion/commits/master

I changed requirements to point to this and was able to submit a review as superuser. going to test account posted previously.

danrjohnson · 2015-05-14T17:28:47Z

Can confirm working with test account posted earlier.

codersquid · 2015-05-14T17:33:10Z

Thanks @danrjohnson and I submitted an issue to the pinax/symposion project to get it fixed there too pinax/symposion#72

danrjohnson · 2015-05-14T17:34:57Z

@lsilen All the changes applied to seattle are also applied to london as of this writing.

lsilen · 2015-05-14T17:40:26Z

I just tried to vote +1 for Graham Markall's tutorial on London and it's not showing up. this was form my super user account.

lsilen · 2015-05-14T17:44:42Z

I set up a different account and when I try to go to http://london.pydata.org/teams/reviewers/ I get a Page not found error.

danrjohnson · 2015-05-14T17:45:59Z

@lsilen I do need to setup the reviewers account for london, which i will do now

did you fill out comments when you +1'd. If you don't, it won't accept the +1. (if you click back to the tab you'll see an error)

codersquid · 2015-05-14T17:46:04Z

I don't have time to check this right now, but I remember something happening with scipy last year with respect to voting, here's the issue scipy-conference/SciPy-2014#78

I thought it had to do with a mysql thing, so it might not apply to us since we are using postgresql but please noticed.

danrjohnson · 2015-05-14T17:48:05Z

@codersquid That seems to be the same error as the one listed earlier for Decimal conversion, just with mysql errors instead of postgres errors. It does seem to be a type conversion problem.

codersquid · 2015-05-14T17:48:42Z

On Thu, May 14, 2015 at 12:46 PM, Dan Johnson [email protected]
wrote:

did you fill out comments when you +1'd. If you don't, it won't accept the
+1. (if you click back to the tab you'll see an error)

might want to open a new issue so that we have a help text to show the user
about comment being required

[email protected]

codersquid · 2015-05-14T17:49:30Z

I wonder if the other commit in euroscipy/symposion was an attempt to fix
this?

On Thu, May 14, 2015 at 12:48 PM, Dan Johnson [email protected]
wrote:

@codersquid https://github.com/codersquid That seems to be the same
error as the one listed earlier for Decimal conversion, just with mysql
errors instead of postgres errors. It does seem to be a type conversion
problem.

—
Reply to this email directly or view it on GitHub
#57 (comment).

[email protected]

lsilen · 2015-05-14T18:18:05Z

I didn’t comment, but I didn’t on the Seattle one I voted on either and it seemed to register the +1. Do I need to let folks know they have to comment for their rating to count?

danrjohnson · 2015-05-14T18:20:11Z

@lsilen Yes, I think that would be a good idea.

Also, http://london.pydata.org/teams/reviewers/ is up.

lsilen · 2015-05-14T18:31:01Z

can I delete the votes?

danrjohnson · 2015-05-14T19:36:32Z

@lsilen I've deleted all the reviews off of london and seattle.

lsilen · 2015-05-14T21:07:00Z

Thanks Dan!

jeffsedik · 2015-05-14T21:55:58Z

@lsilen - can we close this issue?

lsilen · 2015-05-14T22:15:22Z

I think so! I just sent out the link for the committee to apply.

On May 14, 2015, at 4:56 PM, jeffsedik [email protected] wrote:

@lsilen https://github.com/lsilen - can we close this issue?

—
Reply to this email directly or view it on GitHub #57 (comment).

Leah Silen
Executive Director
NumFOCUS http://numfocus.org/
[email protected]
512-222-5449

jeffsedik assigned danrjohnson May 12, 2015

codersquid added the high priority label May 13, 2015

jeffsedik closed this as completed May 19, 2015

Proposal review not working in admin. #57

Proposal review not working in admin. #57

Comments

lsilen commented May 12, 2015

jeffsedik commented May 12, 2015

lsilen commented May 12, 2015

codersquid commented May 12, 2015

codersquid commented May 12, 2015

lsilen commented May 12, 2015

codersquid commented May 12, 2015

lsilen commented May 12, 2015

lsilen commented May 12, 2015

jeffsedik commented May 12, 2015

codersquid commented May 12, 2015

codersquid commented May 12, 2015

danrjohnson commented May 12, 2015

lsilen commented May 12, 2015

lsilen commented May 13, 2015

jeffsedik commented May 13, 2015

lsilen commented May 13, 2015

jeffsedik commented May 13, 2015

danrjohnson commented May 13, 2015

lsilen commented May 13, 2015

danrjohnson commented May 13, 2015

lsilen commented May 13, 2015

lsilen commented May 13, 2015

codersquid commented May 13, 2015

codersquid commented May 13, 2015

codersquid commented May 13, 2015

lsilen commented May 13, 2015

danrjohnson commented May 13, 2015

danrjohnson commented May 13, 2015

lsilen commented May 14, 2015

jeffsedik commented May 14, 2015

lsilen commented May 14, 2015

lsilen commented May 14, 2015

jeffsedik commented May 14, 2015

lsilen commented May 14, 2015

lsilen commented May 14, 2015

jeffsedik commented May 14, 2015

lsilen commented May 14, 2015

danrjohnson commented May 14, 2015

codersquid commented May 14, 2015

danrjohnson commented May 14, 2015

danrjohnson commented May 14, 2015

codersquid commented May 14, 2015

danrjohnson commented May 14, 2015

lsilen commented May 14, 2015

lsilen commented May 14, 2015

danrjohnson commented May 14, 2015

codersquid commented May 14, 2015

danrjohnson commented May 14, 2015

codersquid commented May 14, 2015

codersquid commented May 14, 2015

lsilen commented May 14, 2015

danrjohnson commented May 14, 2015

lsilen commented May 14, 2015

danrjohnson commented May 14, 2015

lsilen commented May 14, 2015

jeffsedik commented May 14, 2015

lsilen commented May 14, 2015