-
Notifications
You must be signed in to change notification settings - Fork 13
feat: add support to output resources #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The pyright action is failing - but tbh I did not touch most of the code. Can happily fix the issues, but wanted to ask before :) |
|
@Kigstn Thanks Daniel! Can you pull the |
|
Note that we'll want to think about how this interacts with #9 |
|
@DouweM of course, done! Gernally - Happy to adapt things, just give me some feedback :) I made a 2nd tiny PR for the verbose changes |
@Kigstn Yeah we'll need to support parallel runs. Could we use a virtual FS that's only mounted into a specific run, instead of a real directory on disk? I also think this should be an opt-in feature, so we don't change people's existing usage of the mcp server if they just want text output, no files. |
|
I totally missed that, thank you @Kigstn! |
I will investigate this. From a quick look a virtual FS will not solve the problem, as you simple can't re-mount the same directory. I am going to look at either:
Any preferences @DouweM ? :) |
|
And for opt-in, that makes sense & is very reasonable :) |
|
@Kigstn Ah the issue is that we're using the same Pyodide instance, right. Then in this scenario I think multiple instances makes sense. |
|
Alright @DouweM - I think it's now ready. As you can see, getting this to run was a bit more complicated & required more changes. So have fun with the review 😅 So what changed:
|
|
Also have a question regarding the failing test: it's a performance test I added to check that worker creation (which takes 2-3s) is not repeated constantly. So I fire 500 super simple code snippets against it and test the time. Locally that takes 15s to run, on CI 25ish. The problem however is that due to the CI worker running the test for all python versions, this is super slow & inconsistent. Personally, I would move these tests out of Ci and maybe into their own Ci instance where it is only run once. Otherwise the benchmarking will always be inconsistent... Or these tests can be removed / only exist locally |
This PR adds support for the server to output files.
This is done via Embedded Ressources
This allows this server to do cool stuff like generate matplotlib graphs :)