-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove export of silly OpenSSL functions #12223
Comments
What's the motivation for this? pyOpenSSL makes use of these, so we can't simply remove them, we'd have to remove the callers there and do a release cycle. Do all OpenSSL forks document the same guarantees? Assuming yes, I'm happy to take a PR for this (starting with the pyOpenSSL side), but I don't think any of the maintainers are likely to make time for it. |
I’m happy to make time to review, but won’t author the PRs (assuming the forks we support all make the same guarantees) |
Yes LibreSSL and BoringSSL do the same thing, inherited from the original indirection in OpenSSL. I'll make a PR at some point, thanks. |
This issue has been waiting for a reporter response for 3 days. It will be auto-closed if no activity occurs in the next 5 days. |
Close if you want, a couple of silly needless functions won't really hurt the ecosystem. But I will try to do something. |
That’s just the automated bot which isn’t very smart. We remain happy to review the PRs. |
It would be nice if you removed use of
X509_get_default_cert_dir_env
as it just returns the value "SSL_CERT_DIR"X509_get_default_cert_dir_env
as it just returns the value "SSL_CERT_FILE"Those values are documented in man7/openssl-env.
The text was updated successfully, but these errors were encountered: