Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include PyBaMM solution in OptimisationResult #548

Open
BradyPlanden opened this issue Nov 5, 2024 · 0 comments · May be fixed by #573
Open

Include PyBaMM solution in OptimisationResult #548

BradyPlanden opened this issue Nov 5, 2024 · 0 comments · May be fixed by #573
Labels
enhancement New feature or request

Comments

@BradyPlanden
Copy link
Member

Feature description

Including the PyBaMM solution object inside the OptimisationResult.

Motivation

Provide the solution of state and processed variables for visualisation, debugging, etc.

Possible implementation

A few possible methods:

  • Call the BaseModel.simulate with optimised inputs, corresponding t_eval
  • Add a method to the BaseProblem to handle t_eval and model setup, call said method
  • Completely refactor BaseProblem.evaluate so that the returned object is a pybamm.solution. Simply store the final solution in the OptimisationResult

Additional context

No response
@BradyPlanden BradyPlanden added the enhancement New feature or request label Nov 5, 2024
@pipliggins pipliggins linked a pull request Dec 2, 2024 that will close this issue
Draft
7 tasks
@BradyPlanden BradyPlanden moved this to In Progress in v24.12 Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
v24.12
Status: In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Include PyBaMM solution in OptimizationResult pipliggins/PyBOP
1 participant
@BradyPlanden