-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
random_search optimiser added in the pints framework #580
Open
Dibyendu-IITKGP
wants to merge
8
commits into
develop
Choose a base branch
from
440-add-a-random-sample-optimiser
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dibyendu-IITKGP
force-pushed
the
440-add-a-random-sample-optimiser
branch
from
December 5, 2024 12:57
3dc64bf
to
2d5c7d2
Compare
Dibyendu-IITKGP
force-pushed
the
440-add-a-random-sample-optimiser
branch
from
December 5, 2024 13:00
42cb8cc
to
54bf352
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #580 +/- ##
===========================================
- Coverage 99.08% 98.53% -0.55%
===========================================
Files 52 57 +5
Lines 3605 4028 +423
===========================================
+ Hits 3572 3969 +397
- Misses 33 59 +26 ☔ View full report in Codecov by Sentry. |
…0-add-a-random-sample-optimiser
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a simplistic random search optimiser, with the following API:
optim = pybop.RandomSearch( cost, max_iterations=1000, max_unchanged_iterations=100, population_size=50)
Issue reference
Fixes #440
Review
Before you mark your PR as ready for review, please ensure that you've considered the following:
Type of change
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ nox -s tests
$ nox -s doctest
You can run integration tests, unit tests, and doctests together at once, using
$ nox -s quick
.Further checks: