Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option for voltage/current variable names and frequency response of internal variables #33

Open
whileman133 opened this issue Feb 4, 2025 · 0 comments

Comments

@whileman133
Copy link

whileman133 commented Feb 4, 2025

@rtimms @noelhallemans, in my research group at the University of Colorado Colorado Springs, we've defined lumped-parameter LIB/LMB models with slightly different variable names ("vcell [V]" instead of "Voltage [V]" and "iapp [A]" instead of "Current [A]"). Rather than reference "Voltage [V]" and "Current [A]" directly in the EISSimulation class, could these names be passed to the initializer for improved generality with model definitions?

Also: we'd find it useful to evaluate the frequency response of a cell's internal variables (in addition to the cell-level impedance) for comparison with our transfer function models. Do you have thoughts on what changes are needed to support this?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant