Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate number of electrodes in parallel to make a cell #4833

Open
aabills opened this issue Feb 10, 2025 · 0 comments
Open

Deprecate number of electrodes in parallel to make a cell #4833

aabills opened this issue Feb 10, 2025 · 0 comments

Comments

@aabills
Copy link
Contributor

aabills commented Feb 10, 2025

The "Number of electrodes connected in parallel to make a cell" parameter is confusing and not always used properly. For example, it is not used to calculate the area of the current collector:

self.A_cc = self.L_y * self.L_z # Current collector cross sectional area
, which is used to calculate the "total lithium in the electrolyte":
self.n_Li_e_init = c_e_av_init * self.L_x * self.A_cc

We could go through and try and find and fix all of these, or we could just deprecate this parameter. I think we should do the latter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant