Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quickplot with discharge capacity as x axis #1751

Open
rtimms opened this issue Oct 19, 2021 · 5 comments · May be fixed by #4775
Open

Quickplot with discharge capacity as x axis #1751

rtimms opened this issue Oct 19, 2021 · 5 comments · May be fixed by #4775
Assignees
@casualPhysics
Labels
difficulty: easy A good issue for someone new. Can be done in a few hours priority: low No existing plans to resolve

Comments

@rtimms
Copy link
Contributor

rtimms commented Oct 19, 2021

It would be nice if you could make a QuickPlot with discharge capacity as the x-axis instead of time. This would make it easier to compare solutions where the C-rate is different, for example.
@valentinsulzer valentinsulzer added the difficulty: easy A good issue for someone new. Can be done in a few hours label Oct 19, 2021
@soma2000-lang
Copy link
Contributor

@rtimms Sorry for the silly question but can you please mention the file name in which the changes need to be done

@rtimms
Copy link
Contributor Author

rtimms commented Mar 12, 2022

In QuickPlot here. At the moment you can choose a time unit (hours, minutes, seconds). It would be good to instead of plotting vs time have the option to plot as a function of the variable “Discharge capacity [A.h]”.

@soma2000-lang
Copy link
Contributor

Ok

@Saransh-cpp
Copy link
Member

I started working on this issue last year but couldn't complete it. I have pushed the local branch on my fork, it might help - https://github.com/Saransh-cpp/PyBaMM/blob/issue-1751-discharge-capacity-as-x-axis/pybamm/plotting/quick_plot.py

@valentinsulzer valentinsulzer added the priority: low No existing plans to resolve label May 8, 2023
@casualPhysics
Copy link

Is anyone working on this currently? I'll be happy to give it a go if not. First time contributor here.

@medha-14 medha-14 linked a pull request Jan 19, 2025 that will close this issue
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@casualPhysics casualPhysics

Labels
difficulty: easy A good issue for someone new. Can be done in a few hours priority: low No existing plans to resolve
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement discharge capacity as an optional x-axis in QuickPlot medha-14/PyBaMM
7 participants
@valentinsulzer @casualPhysics @brosaplanella @rtimms @soma2000-lang @Saransh-cpp @agriyakhetarpal