Revert "Modifies QuickPlot.plot ..."
#4622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…perimposed plots in case of 1D variables. (pybamm-team#4529)" This reverts commit b50d4a9.
kratman
requested review from
martinjrobins,
rtimms,
Saransh-cpp,
valentinsulzer and
agriyakhetarpal
as code owners
kratman
commented
Nov 27, 2024
kratman
commented
Nov 27, 2024
valentinsulzer
approved these changes
Nov 27, 2024
|
@medha-14 Since this is a revert, you will have to re-implement your changes. You can use the git diff to create a new branch |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4622 +/- ##
===========================================
+ Coverage 99.18% 99.21% +0.03%
===========================================
Files 302 302
Lines 22840 22857 +17
===========================================
+ Hits 22654 22678 +24
+ Misses 186 179 -7 ☔ View full report in Codecov by Sentry. |
brosaplanella
approved these changes
Nov 27, 2024
kratman
added a commit
that referenced
this pull request
Nov 27, 2024
* Revert "Modifies `QuickPlot.plot` to take a list of times and show superimposed plots in case of 1D variables. (#4529)" This reverts commit b50d4a9. * style: pre-commit fixes * Fix changelog with PR number --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This reverts commit b50d4a9.
Fixes #4620
Type of change
Key checklist:
$ pre-commit run(or$ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python run-tests.py --all(or$ nox -s tests)$ python run-tests.py --doctest(or$ nox -s doctests)You can run integration tests, unit tests, and doctests together at once, using
$ python run-tests.py --quick(or$ nox -s quick).Further checks: