Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync main and 24.11.1 #4605

Merged
merged 5 commits into from
Nov 23, 2024
Merged

Sync main and 24.11.1 #4605

merged 5 commits into from
Nov 23, 2024

Conversation

kratman
Copy link
Contributor

@kratman kratman commented Nov 23, 2024

Due to a merge conflict, I had to sync this in a different branch

medha-14 and others added 5 commits November 22, 2024 18:19
…ed plots in case of 1D variables. (pybamm-team#4529)

* Modified  plot method to take a list of times .

* fixed failing tests

* added different colours to different time plots

* fixed failing tests

* added tests for using list of times

* added changelog enrty

* made small changes

* Update CHANGELOG.md

Co-authored-by: Agriya Khetarpal <[email protected]>

---------

Co-authored-by: Arjun Verma <[email protected]>
Co-authored-by: Eric G. Kratz <[email protected]>
Co-authored-by: Agriya Khetarpal <[email protected]>
* Release patches

* Add changelog

* Update CHANGELOG.md
@kratman kratman merged commit 3421fac into pybamm-team:develop Nov 23, 2024
23 of 24 checks passed
@kratman kratman deleted the fix/syncRelease branch November 23, 2024 01:36
Copy link

codecov bot commented Nov 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.22%. Comparing base (204c076) to head (cbb0bd0).
Report is 8 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4605      +/-   ##
===========================================
- Coverage    99.25%   99.22%   -0.04%     
===========================================
  Files          302      302              
  Lines        22838    22821      -17     
===========================================
- Hits         22667    22643      -24     
- Misses         171      178       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants