-
-
Notifications
You must be signed in to change notification settings - Fork 549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement gradient_squared
for FiniteVolume
#2979
Labels
difficulty: easy
A good issue for someone new. Can be done in a few hours
feature
priority: low
No existing plans to resolve
Comments
brosaplanella
added
feature
difficulty: easy
A good issue for someone new. Can be done in a few hours
priority: low
No existing plans to resolve
labels
May 23, 2023
@brosaplanella can you assign it to me ? |
I have tried to implemented the gradient square using the previously discussed method. I am open to exploring other implementations as well. If you have any suggestions.
|
Hi! Could you please open a PR? It will be easier to discuss there as we will be able to see all the changes & tests. |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
difficulty: easy
A good issue for someone new. Can be done in a few hours
feature
priority: low
No existing plans to resolve
Description
At the moment
FiniteVolume
does not have agradient_squared
method, so it needs to be computed as the inner product of the gradient with itself.Motivation
Implementing it would allow some code simplifications in the heat sources (Ohmic & heat of mixing).
Possible Implementation
Main issue is to find how we want to implement it (mathematically). If the discretised gradient of
u
isL u
, then the gradient squared is justu^T L^T L u
, where superscriptT
means transpose. Is this too naive?Additional context
No Response
The text was updated successfully, but these errors were encountered: