Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heat source terms by domain #2206

Open
rtimms opened this issue Aug 1, 2022 · 2 comments
Open

Heat source terms by domain #2206

rtimms opened this issue Aug 1, 2022 · 2 comments
Assignees
Labels
difficulty: medium Will take a few days feature priority: low No existing plans to resolve

Comments

@rtimms
Copy link
Contributor

rtimms commented Aug 1, 2022

Description

Add variables e.g. "Negative electrode Ohmic heating [W.m-3]".

Note: depending on which submodel is used, "Electrolyte current density" isn't always a concatenation, so can't be split by domain. Should be able to change this though?

Motivation

No response

Possible Implementation

No response

Additional context

No response

@rtimms rtimms added the feature label Aug 1, 2022
@rtimms rtimms added difficulty: medium Will take a few days priority: low No existing plans to resolve labels May 15, 2023
@rtimms
Copy link
Contributor Author

rtimms commented Nov 22, 2024

tagging @aabills

@aabills
Copy link
Contributor

aabills commented Nov 22, 2024

The issue with electrolyte current density still stands, so I don't think we can close this.

But, it should be closed by the second part of our intended submodel refactor, which should change the electrolyte current density.

@aabills aabills self-assigned this Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium Will take a few days feature priority: low No existing plans to resolve
Projects
None yet
Development

No branches or pull requests

2 participants