Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: accessibility issue with tables in light mode of the theme #39

Open
lwasser opened this issue Jan 30, 2025 · 0 comments
Open

Bug: accessibility issue with tables in light mode of the theme #39

lwasser opened this issue Jan 30, 2025 · 0 comments
Labels
help wanted pyOpenSci would love help with this issue! sprintable An issue that is ideal for a pyOpenSci sprint

Comments

@lwasser
Copy link
Member

lwasser commented Jan 30, 2025

in the _tables.scss file we have this

@media (prefers-color-scheme: dark) {
  td:not(.row-header):nth-child(1) {
    background-color: var(--pst-color-tbl-row); /* Adjust the dark mode color */
    color: #ffffff; /* Adjust the text color for better contrast */
    font-weight: 500;
  }

it appears as if the preferred color scheme won't work here because there is a light and dark mode in the theme. in light mode, tables now look like this where the styles in the first column are modified for dark mode but the second is not. but i'm clearly not in dark mode. it might be best to remove the table styling altogether for this as you can see below, the default styles do render nicely in the default theme.

Image Image

we should add some tables (if they don't exist) to our docs to also test this.

Update: it's a style only on the first column. so that should be easy to remove. The style would be ok IF the background was dark, but it's not.

Image
@lwasser lwasser added help wanted pyOpenSci would love help with this issue! sprintable An issue that is ideal for a pyOpenSci sprint labels Jan 30, 2025
@lwasser lwasser changed the title accessibility issue with tables Big: accessibility issue with tables in light mode of the theme Jan 30, 2025
@lwasser lwasser changed the title Big: accessibility issue with tables in light mode of the theme Bug: accessibility issue with tables in light mode of the theme Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted pyOpenSci would love help with this issue! sprintable An issue that is ideal for a pyOpenSci sprint
Projects
None yet
Development

No branches or pull requests

1 participant