New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in draw brought up by researcher #69

Open

adam2392 opened this issue Mar 21, 2023 · 1 comment

Collaborator

adam2392 commented Mar 21, 2023

pywhy-graphs/pywhy_graphs/viz/draw.py

Lines 118 to 121 in 20661f1

    
           for parent in G.predecessors(v): 
        
               # memoize if we have seen the bidirected circular edge before 
        
               if f"{child}-{parent}" in found_circle_sibs or f"{parent}-{child}" in found_circle_sibs: 
        
                   continue

Collaborator Author

adam2392 commented Jul 12, 2023

This has been resolved.

However, another issue I noticed is we should be able to handle drawing of purely undirected graphs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment