Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check edge types allowed given a graph_type passed in export functions #61

Open
adam2392 opened this issue Mar 7, 2023 · 1 comment

Comments

@adam2392
Copy link
Collaborator

adam2392 commented Mar 7, 2023

          What happens if a user has `graph_type="dag"` instead here? Will this function detect that there are `o->` edges and prevent that? Clearly the imported file does not represent a DAG so we shouldn't let the user make this mistake. Or we should have clear tests to show what happens when you import a graph under a different graph assumption than the one it was created with

Originally posted by @jaron-lee in #60 (comment)

@adam2392
Copy link
Collaborator Author

adam2392 commented Mar 8, 2023

This is mainly for robustness and error-checking within the export submodule

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant