Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Networkx] Rewrite internals of MixedEdgeGraph to have a similar API, but simplified internals #51

Open
adam2392 opened this issue Feb 14, 2023 · 0 comments
Milestone

Comments

@adam2392
Copy link
Collaborator

adam2392 commented Feb 14, 2023

A lot of the mixedEdgeGraph internals was essentially copied over from networkx. I think with the assumption that "maybe" we could've kept similar internal data structures like _adj, _nodes, etc. Pretty much the only thing that works is _nodes because _adj is a very specific format for storing nested dicts. This issue is just to track what needs to eventually get rewritten for robustness.

Some of the existing code can be simplified because we don't have some of these underlying internals. Rather we let the networkx subgraphs deal w/ them. For example:

  • subgraph does't work with subclasses
@adam2392 adam2392 added this to the Release v0.1 milestone Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant