Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests that run against the latest stable version of dodiscover #30

Open
adam2392 opened this issue Jan 5, 2023 · 0 comments

Comments

@adam2392
Copy link
Collaborator

adam2392 commented Jan 5, 2023

Is your feature request related to a problem? Please describe.
Causal graphs and their implementation inherently affect all upstream causal inference procedures. Most importantly dodiscover relies on the API of pywhy-graphs. Any changes introduced here should not break the "next version of dodiscover". In order to catch these, we need integration tests.

Describe the solution you'd like
There are three options:

  1. integration tests in pywhy-graphs
  2. integration tests in dodiscover
  3. integration tests in both

I am leaning towards adding this to dodiscover only, or both. We can delete one of them down the line, but the CI times are already pretty fast, so we can sacrifice this for the sake of ensuring integrability across the two packages (and eventually dowhy).

The solution would just be to create a tight "accuracy" constraint on causal discovery algorithms that leverage each graph class and then this performance should not change across any changes done in pywhy_graphs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant