Instead of deleting e2e repo when tests succeed, delete them when PR closes

Author: ewjoachim

.github/workflows/e2e-delete-repo.yml

@@ -0,0 +1,20 @@
+name: Delete end-to-end test repos on PR close
+
+on:
+  pull_request_target:
+    types:
+      - closed
+
+jobs:
+  test:
+    name: Publish coverage comment
+    runs-on: ubuntu-latest
+    steps:
+      - run: |
+          gh repo delete --yes https://github.com/mihcaojwe/python-coverage-comment-action-end-to-end-${NUMBER}-public || true
+        env:
+          GITHUB_TOKEN: ${{ secrets.COVERAGE_COMMENT_E2E_GITHUB_TOKEN_USER_1 }}
+      - run: |
+          gh repo delete --yes https://github.com/mihcaojwe/python-coverage-comment-action-end-to-end-${NUMBER}-private || true
+        env:
+          GITHUB_TOKEN: ${{ secrets.COVERAGE_COMMENT_E2E_GITHUB_TOKEN_USER_2 }}

tests/end_to_end/conftest.py

@@ -294,19 +294,15 @@ def f(*args):
 
     yield f
 
-    if not is_failed():
-        gh_delete_repo(gh_me)
-
-    else:
-        for username, permission in team_users_permissions.items():
-            gh_me(
-                "api",
-                "--method",
-                "PUT",
-                f"/repos/{{owner}}/{{repo}}/collaborators/{username}",
-                "-f",
-                f"permission={permission}",
-            )
+    for username, permission in team_users_permissions.items():
+        gh_me(
+            "api",
+            "--method",
+            "PUT",
+            f"/repos/{{owner}}/{{repo}}/collaborators/{username}",
+            "-f",
+            f"permission={permission}",
+        )
 
 
 @pytest.fixture
@@ -321,8 +317,6 @@ def f():
         gh_other("repo", "fork", "--clone", f"{gh_me_username}/{repo_name}", "--", ".")
 
     yield f
-    if not is_failed():
-        gh_delete_repo(gh_other)
 
 
 @pytest.fixture