Skip to content

Commit 542b555

Browse files
committed
fix: refactor doc comments and keep internal _prep_inputs_tracking
1 parent aae7eb7 commit 542b555

3 files changed

Lines changed: 5 additions & 29 deletions

File tree

‎docs/sphinx/source/whatsnew/v0.15.2.rst‎

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -10,15 +10,11 @@ Breaking Changes
1010

1111
Deprecations
1212
~~~~~~~~~~~~
13-
* The function :py:func:`pvlib.clearsky._is_leap_year` is deprecated and will be
14-
removed in v0.17.0. Use :py:func:`pandas.Timestamp.is_leap_year` instead.
15-
(:issue: `2764`, :pull:`2766`)
16-
* The function :py:func:`pvlib.irradiance._liujordan` is deprecated and will be
17-
removed in v0.17.0. (:issue: `2764`, :pull:`2766`)
18-
* The function :py:func:`pvlib.modelchain.get_orientation` is deprecated and will
19-
be removed in v0.17.0. (:issue: `2764`, :pull:`2766`)
20-
* The method :py:meth:`pvlib.modelchain.ModelChain._prep_inputs_tracking` is
21-
deprecated and will be removed in v0.17.0. (:issue: `2764`, :pull:`2766`)
13+
* The following functions have been deprecated and will be removed in v0.17.0:
14+
- :py:func:`pvlib.clearsky._is_leap_year` (use :py:func:`pandas.Timestamp.is_leap_year` instead)
15+
(:issue: `2764`, :pull:`2766`)
16+
- :py:func:`pvlib.irradiance._liujordan` (:issue: `2764`, :pull:`2766`)
17+
- :py:func:`pvlib.modelchain.get_orientation` (:issue: `2764`, :pull:`2766`)
2218

2319

2420
Bug fixes

‎pvlib/modelchain.py‎

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1252,13 +1252,6 @@ def _prep_inputs_airmass(self):
12521252
model=self.airmass_model)
12531253
return self
12541254

1255-
@deprecated(
1256-
since="0.15.2",
1257-
removal="0.17.0",
1258-
name="Modelchain._prep_inputs_tracking",
1259-
alternative=None,
1260-
addendum=None,
1261-
)
12621255
def _prep_inputs_tracking(self):
12631256
"""
12641257
Calculate tracker position and AOI

‎tests/test_modelchain.py‎

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1818,19 +1818,6 @@ def test_get_orientation_deprecation():
18181818
assert surface_azimuth == 180
18191819

18201820

1821-
@fail_on_pvlib_version('0.17.0')
1822-
def test_prep_inputs_tracking_deprecation(sapm_dc_snl_ac_system, location):
1823-
mc = ModelChain(sapm_dc_snl_ac_system, location)
1824-
# Set up mock results and system attributes required by the method
1825-
mc.results = MagicMock()
1826-
mc.system.singleaxis = MagicMock()
1827-
mc.system.axis_tilt = 0.0
1828-
mc.system.axis_azimuth = 180.0
1829-
with pytest.warns(pvlibDeprecationWarning,
1830-
match='will be removed in 0.17.0.'):
1831-
mc._prep_inputs_tracking()
1832-
1833-
18341821
# tests for PVSystem with multiple Arrays
18351822
def test_with_sapm_pvsystem_arrays(sapm_dc_snl_ac_system_Array, location,
18361823
weather):

0 commit comments

Comments
 (0)