Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

😈 [Feature Enhancement] - Transform channel operation functions to take channelAddress in the form of bytes32 instead of address #406

Closed
0xNilesh opened this issue Jul 23, 2024 · 0 comments · Fixed by #410
Assignees

Comments

@0xNilesh
Copy link
Member

0xNilesh commented Jul 23, 2024

Feature name

No response

Describe the Enhancement

Transform channel operation functions to take channelAddress in the form of bytes32 instead of address (required for non-EVM)

  1. blockChannel
  2. getChannelVerification
  3. batchVerification
  4. verifyChannel
  5. unverifyChannel

This will require the following changes.

Changing all the parameters from address to bytes32.
Using the bytes32 format for msg.sender in verifyChannel function.
Accept bytes32 in onlyActivatedChannels private function.
Create new mapping for channelUpdateCounter as we go non-EVM.

POC if available

No response

Contract Name

Core Contract

@Zartaj0 Zartaj0 linked a pull request Jul 25, 2024 that will close this issue
@Zartaj0 Zartaj0 closed this as completed Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants