Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

😈 [Feature Enhancement] - Include a feature to update PROTOCOL_POOL_FEES via crosschain #396

Closed
Zartaj0 opened this issue Jul 10, 2024 · 0 comments · Fixed by #399
Closed
Assignees
Labels
bug Something isn't working priority-1 Indicates highest priority

Comments

@Zartaj0
Copy link
Member

Zartaj0 commented Jul 10, 2024

Feature name

Comm contract sends Pool fees to core on mainnet, but doesn't update the PROTOCOL_POOL_FEES

Describe the Enhancement

Include a way so that anytime there is a direct token transfer from Comm on any chain to core on mainnet, the PROTOCOL_POOL_FEES gets updated in core, preventing any fund loss.

POC if available

No response

Contract Name

Core Contract

@zaryab2000 zaryab2000 changed the title 😈 [Feature Enhancement] - Include a feature to update RPROTOCOL_POOL_FEES via crosschain 😈 [Feature Enhancement] - Include a feature to update PROTOCOL_POOL_FEES via crosschain Jul 12, 2024
@zaryab2000 zaryab2000 self-assigned this Jul 12, 2024
@zaryab2000 zaryab2000 added bug Something isn't working priority-1 Indicates highest priority labels Jul 12, 2024
@0xNilesh 0xNilesh linked a pull request Jul 23, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority-1 Indicates highest priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants