Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

😈 [Feature Enhancement] - <Include migration function for address to bytes32 for channels> #376

Closed
zaryab2000 opened this issue Jun 3, 2024 · 0 comments · Fixed by #379
Assignees
Labels
priority-1 Indicates highest priority support

Comments

@zaryab2000
Copy link
Collaborator

Feature name

With bytes32 support for channel, we also need a migration function

Describe the Enhancement

Expected behaviours of migrateChannelBytes32() function:

  • Should be onlyAdmin()
  • Allows migration of all pre-existing channels to shift from address to bytes32 as channel identifier
  • Can only be called when contract is PAUSED
  • TBD( emit out event ChannelCreated with bytes for every new channel migrated)

Note: Create new branch from 371-address-to-bytes32 branch

POC if available

No response

Contract Name

Core Contract

@zaryab2000 zaryab2000 added priority-1 Indicates highest priority support labels Jun 3, 2024
@Zartaj0 Zartaj0 linked a pull request Jun 4, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority-1 Indicates highest priority support
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants