Skip to content

Use package from pursuit that doesn't have spago.yaml #1300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
flip111 opened this issue Nov 5, 2024 · 2 comments
Closed

Use package from pursuit that doesn't have spago.yaml #1300

flip111 opened this issue Nov 5, 2024 · 2 comments

Comments

@flip111
Copy link
Contributor

flip111 commented Nov 5, 2024

I vaguely remember this might have been discussed somewhere before. But i'm not sure if it does have it's own ticket.

I like to use this package https://pursuit.purescript.org/packages/purescript-web-dom/6.0.0/docs/Web.DOM
But than the latest version because of this commit purescript-web/purescript-web-dom#59

I specify it like this

workspace:
  packageSet:
    registry: 60.7.0
  extraPackages:
    web-dom:
      git: https://github.com/purescript-web/purescript-web-dom.git
      ref: master

This is my console output

» spago run --backend-args '--help'
Reading Spago workspace configuration...

✓ Selecting package to build: html2halogen

Cloning https://github.com/purescript-web/purescript-web-dom.git

✘ Could not read config at .spago/p/web-dom/master
Error:
  Did not find `.spago/p/web-dom/master/spago.yaml`.

By the way, perhaps the error message can be improved a bit as well. As far as i understood the config must always be called "spago.yaml" so "could not read" and "did not find" seem a bit double. What about Could not find the spago.yaml config file in web-dom?

@f-f
Copy link
Member

f-f commented Nov 5, 2024

Happy to merge improvements to error messages.

Docs for this are here, quoting:

If the upstream library that you are adding has a spago.yaml file, then Spago will just pick up the dependencies from there. If that's not the case, then you'll have the provide the dependencies yourself, adding a dependencies field.

@f-f f-f closed this as completed Nov 5, 2024
@flip111
Copy link
Contributor Author

flip111 commented Nov 5, 2024

ok got it. Why close the issue though? In this case there is a good workaround to which the error message could point. Is that not a todo worth of the issue being open?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants