Skip to content

Localization #85

@CarstenKoenig

Description

@CarstenKoenig
Contributor

Hi,

I'm actually not sure if this is an issue at all (meaning if there is not already a workaround I don't see - if so sorry) - but here we go:

I happen to write apps mainly for German speaking folks and here it's not 1,123.45 it's 1.123,45 (yeah stupid but hey 🤷).
It's not really a big deal as some simple replacing afterwards fixes this but still folks might be interested in having this in the library.

Proposed solution
I think having optional parameters for the thousand- and decimal-separator-characters defaulting to those here for the number-Formatter might be a good start.

I'd happily volunteer to implement such a change if you are interested in it.

What do you think?

Activity

garyb

garyb commented on Feb 8, 2023

@garyb
Member

Sounds good to me 👍

CarstenKoenig

CarstenKoenig commented on Feb 8, 2023

@CarstenKoenig
ContributorAuthor

all right - I'll give it a try - thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @garyb@CarstenKoenig

        Issue actions

          Localization · Issue #85 · purescript-contrib/purescript-formatters