Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to --password-stdin for authentication in docker::registry #979

Open
dantel35 opened this issue May 16, 2024 · 0 comments
Open

Switch to --password-stdin for authentication in docker::registry #979

dantel35 opened this issue May 16, 2024 · 0 comments

Comments

@dantel35
Copy link

Use Case

I want to be able to authenticate to a private registry in a secure and recommended way, i.e. using --password-stdin and using secrets stored in a vault, not in plaintext in my puppet code/hiera.

Describe the Solution You Would Like

In this module, docker login is not done the recommended way, wich is
cat ~/my_password.txt | docker login --username foo --password-stdin
https://docs.docker.com/reference/cli/docker/login/

Switching to this form of authentication would not only be the recommended way to use docker login, but it would allow to use secrets stored in the vault easily.

Also switching to the recommended way would eliminate the warnings docker registries throw at you when not using "--password-stdin".

Describe Alternatives You've Considered

I tried passing the password parameter with a deferred function - the module does not work this way.

Additional Context

Add any other context or screenshots about the feature request here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant