diff --git a/Gemfile b/Gemfile index c815989b..63ead200 100644 --- a/Gemfile +++ b/Gemfile @@ -19,11 +19,21 @@ group :tests do # since the Resource API runs inside the puppetserver, test against the JRuby versions we ship # these require special dependencies to have everything load properly # rubocop 1.48 supports JRuby 9.3+, which includes coverage for versions we support; 1.64.0 fixes a bug - gem 'rubocop', '~> 1.50.0', require: false - gem 'rubocop-rspec', ['~> 2.20', '!= 2.31.0'], require: false - gem 'rubocop-performance', '~> 1.16', require: false - gem 'rubocop-factory_bot', '!= 2.26.0', require: false - gem 'rubocop-rspec_rails', '!= 2.29.0', require: false + # gem 'rubocop', '~> 1.50.0', require: false + # gem 'rubocop-rspec', ['~> 2.20', '!= 2.31.0'], require: false + # gem 'rubocop-performance', '~> 1.16', require: false + # gem 'rubocop-factory_bot', '!= 2.26.0', require: false + # gem 'rubocop-rspec_rails', '!= 2.29.0', require: false + + # ensure the core rubocop gems are pinned as follows: + gem 'rubocop', '1.48.1', require: false + gem 'rubocop-rspec', '2.31.0', require: false + gem 'rubocop-performance', '1.21.0', require: false + # and these as well as they are dependencies of the above + gem 'rubocop-ast', '1.31.3', require: false + gem 'rubocop-capybara', '2.20.0', require: false + gem 'rubocop-factory_bot', '2.25.1', require: false + gem 'rubocop-rspec_rails', '2.28.3', require: false end group :development do diff --git a/analysis/summary.md b/analysis/summary.md index 268d33ca..0a06444b 100644 --- a/analysis/summary.md +++ b/analysis/summary.md @@ -448,6 +448,18 @@ Using scanf 1.0.0 < ➜ analysis git:(cat_1910_fix_nightlies) ✗ ``` +And again, differences with rubocop: + +``` +Fetching rubocop 1.48.1 Fetching rubocop 1.48.1 +Fetching rubocop-ast 1.30.0 | Fetching rubocop-ast 1.31.3 +Fetching rubocop-capybara 2.18.0 | Fetching rubocop-capybara 2.20.0 +Fetching rubocop-performance 1.17.1 | Fetching rubocop-factory_bot 2.25.1 +Fetching rubocop-rspec 2.20.0 | Fetching rubocop-performance 1.21.0 + > Fetching rubocop-rspec 2.31.0 + > Fetching rubocop-rspec_rails 2.28.3 +``` + ## Last Working Nightly What were the gems being installed here? Can I just pin our current to this?