Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When linting with interpolation, triggers false-positive and adds spaces. Repeatedly. #217

Open
nelsonjr opened this issue Oct 11, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@nelsonjr
Copy link

Describe the Bug

When linting a file with a resource with interpolation, it flags it as missing spaces and adds it—every time.

Expected Behavior

Properly detect if spaces are needed, and if run with --fix to update it, but not add more spaces after that.

Steps to Reproduce

  1. Lint a file with this resource:
  apache::vhost { 'test-oidc':
    custom_fragment => @(EOT)
        OIDCProviderMetadataURL xxxxxxxxxxxxxxxxxxxxxxxx
        OIDCClientID xxxxxxxxxxxxxxxxxxxxxxxx
        OIDCClientSecret xxxxxxxxxxxxxxxxxxxxxxxx
    | EOT
  }
  1. Observe that every time, the OIDCProviderMetadataURL line has more spaces. After a few invocations of puppet-lint --fix the resource will look like this:
  apache::vhost { 'test-oidc':
    custom_fragment => @(EOT)
                                      OIDCProviderMetadataURL xxxxxxxxxxxxxxxxxxxxxxxx
        OIDCClientID xxxxxxxxxxxxxxxxxxxxxxxx
        OIDCClientSecret xxxxxxxxxxxxxxxxxxxxxxxx
    | EOT
  }

Environment

  • Version 4.2.4
  • Platform Ubuntu 22.04
  • Puppet 7
@nelsonjr nelsonjr added the bug Something isn't working label Oct 11, 2024
@kenyon
Copy link

kenyon commented Oct 11, 2024

This is a duplicate of voxpupuli/puppet-lint-strict_indent-check#20.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants