Skip to content

Bare control-repo doesn't pass "pdk validate" tests #114

@bschonec

Description

@bschonec

Describe the Bug

The site-modules/adhoc/plans/myplan.pp file doesn't pass a basic 'pdk validate' run.

Expected Behavior

It's expected that control-repo should be able to pass any PDK tests from the main/master branch.

Steps to Reproduce

Steps to reproduce the behavior:

  1. git clone https://github.com/puppetlabs/control-repo.git
  2. cd control-repo
  3. pdk convert (accept all defaults)
  4. pdk validate

Environment

Red Hat Enterprise Linux 7.9
pdk-2.6.1.0-1.el7.x86_64
puppet-agent-7.16.0-1.el7.x86_64

Additional Context

root@example:~/a/control-repo$  pdk validate
pdk (INFO): Using Ruby 2.7.7
pdk (INFO): Using Puppet 7.22.0
pdk (INFO): Running all available validators...
pdk (INFO): Validator 'puppet-epp' skipped for '/home/a/control-repo'. No files matching '["**/*.epp"]' found to validate.
pdk (INFO): Validator 'task-name' skipped for '/home/a/control-repo'. No files matching '["tasks/**/*"]' found to validate.
pdk (INFO): Validator 'task-metadata-lint' skipped for '/home/a/control-repo'. No files matching '["tasks/*.json"]' found to validate.
┌ [✔] Running metadata validators ...
├── [✔] Checking metadata syntax (metadata.json tasks/*.json).
└── [✔] Checking module metadata style (metadata.json).
┌ [✖] Running puppet validators ...
├── [✖] Checking Puppet manifest syntax (**/*.pp).
└── [✖] Checking Puppet manifest style (**/*.pp).
┌ [✔] Running ruby validators ...
└── [✔] Checking Ruby code style (**/**.rb).
┌ [✔] Running tasks validators ...
├── [✔] Checking task names (tasks/**/*).
└── [✔] Checking task metadata style (tasks/*.json).
┌ [✔] Running yaml validators ...
└── [✔] Checking YAML syntax (**/*.yaml **/*.yml).
pdk (ERROR): puppet-syntax: Could not parse for environment production: Syntax error at 'targets' (site-modules/adhoc/plans/myplan.pp:4:14)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @bschonec

        Issue actions

          Bare control-repo doesn't pass "pdk validate" tests · Issue #114 · puppetlabs/control-repo