Skip to content

Commit dbf047b

Browse files
authored
Merge pull request #16 from punktDe/ImproveFieldValuePreview
[TASK] Use popover to show preview field values
2 parents 6bb1e37 + 8069065 commit dbf047b

File tree

9 files changed

+49
-14
lines changed

9 files changed

+49
-14
lines changed

Documentation/Changelog/Index.rst

+6
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,12 @@
66
Change log
77
==========
88

9+
Version 1.1.0
10+
-------------
11+
- Improve display of field value preview (https://github.com/punktDe/quickedit/issues/14)
12+
- Update example config and known problems page (https://github.com/punktDe/quickedit/issues/20)
13+
14+
915
Version 1.0.1
1016
-------------
1117

Loading

Documentation/KnownProblems/Index.rst

+2-1
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,5 @@
66
Known problems
77
==============
88

9-
No known problems so far.
9+
- If the slug-field is in a fieldgroup without the title field: editing the group with the slug field will also show the title field for editing, even if not configured.
10+
This seems to be some kind of TCA related magic.

Documentation/Settings.cfg

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ project = Quickedit
2525
# ... (recommended) version, displayed next to title (desktop) and in <meta name="book-version"
2626
# .................................................................................
2727

28-
release = 1.0.1
28+
release = 1.1.0
2929

3030
# .................................................................................
3131
# ... (recommended) displayed in footer

README.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -40,12 +40,12 @@ mod {
4040
config {
4141
1 {
4242
label = General
43-
fields = title, subtitle
43+
fields = title, subtitle, slug
4444
previewFields = title
4545
}
4646
2 {
4747
label = Special
48-
fields = slug, hidden, fe_group
48+
fields = hidden, fe_group
4949
previewFields = *
5050
}
5151
}
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
1-
<f:for each="{editConfig.fieldValues}" as="previewField">
2-
<div>
3-
<span>{previewField.label}:</span>&nbsp;
4-
<span>{previewField.value}</span><br />
5-
</div>
6-
</f:for>
1+
<div class='container'>
2+
<f:for each="{editConfig.fieldValues}" as="previewField">
3+
<div class='row'>
4+
<div class='col field-label'>{previewField.label}:</div>
5+
<div class='col'>{previewField.value}</div>
6+
</div>
7+
</f:for>
8+
</div>

Resources/Private/Templates/Backend/Quickedit.html

+8-3
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,14 @@
1414
</be:link.editRecord>
1515

1616
<f:if condition="{editConfig.previewFields}">
17-
<div class="quickedit__field-value" data-bs-toggle="tooltip" title="
18-
{f:render(partial:'FieldValues', arguments:{editConfig:editConfig})}"
19-
data-bs-html="true" data-bs-placement="bottom">
17+
<div class="quickedit__field-value"
18+
data-bs-html="true"
19+
data-bs-placement="bottom"
20+
data-bs-trigger="hover"
21+
data-bs-toggle="popover"
22+
data-bs-content="{f:render(partial:'FieldValues', arguments:{editConfig:editConfig})}"
23+
data-bs-custom-class="quickedit-popover"
24+
>
2025
<f:translate key="LLL:EXT:quickedit/Resources/Private/Language/Backend.xlf:currentValues" />
2126
</div>
2227
</f:if>

Resources/Public/Backend/Css/quickedit.css

+21
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,10 @@
3535
border-top: 1px solid #bbb;
3636
}
3737

38+
.quickedit__field-value {
39+
cursor: pointer;
40+
}
41+
3842
.btn-default.quickedit__toggle-button {
3943
margin-top: -1px;
4044
border-top: none;
@@ -49,3 +53,20 @@
4953
.btn-default.quickedit__toggle-button.collapsed {
5054
background-image: url(../../../../../../../typo3conf/ext/quickedit/Resources/Public/Icons/angle-down-solid.svg);
5155
}
56+
57+
.quickedit-popover {
58+
min-width: 250px;
59+
}
60+
61+
.quickedit-popover .row {
62+
padding: 0.5rem 0;
63+
border-bottom: 1px solid lightgrey;
64+
}
65+
66+
.quickedit-popover .row:last-child {
67+
border: none;
68+
}
69+
70+
.quickedit-popover .field-label {
71+
font-weight: bold;
72+
}

ext_emconf.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
$EM_CONF[$_EXTKEY] = [
33
'title' => 'Toolbar for editing page properties',
44
'description' => 'This extension provides a configurable toolbar for editing page properties.',
5-
'version' => '1.0.1',
5+
'version' => '1.1.0',
66
'category' => 'be',
77
'constraints' => [
88
'depends' => [

0 commit comments

Comments
 (0)