Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setup-pulumi action uses deprecated version of node #36

Closed
ianschmitz opened this issue Oct 25, 2022 · 12 comments
Closed

setup-pulumi action uses deprecated version of node #36

ianschmitz opened this issue Oct 25, 2022 · 12 comments
Labels
kind/bug Some behavior is incorrect or out of spec resolution/wont-fix This issue won't be fixed

Comments

@ianschmitz
Copy link

What happened?

Running a job that uses pulumi/setup-pulumi@v2 results in the following warning from GitHub Actions:

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: pulumi/setup-pulumi

Steps to reproduce

Run a job using the action

Expected Behavior

The action uses a supported version of Node

Actual Behavior

Node 12 actions are deprecated

Output of pulumi about

N/A

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).
@ianschmitz ianschmitz added kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team labels Oct 25, 2022
@Zaid-Ajaj
Copy link

Hi @ianschmitz this issue will be resolved when #35 is merged which is currently blocked by pulumi/actions#753

@Zaid-Ajaj Zaid-Ajaj removed the needs-triage Needs attention from the triage team label Oct 28, 2022
@RobbieMcKinstry
Copy link

RobbieMcKinstry commented Dec 7, 2022 •
edited
Loading

GH has delayed the deprecation of GHE v3.3 until 18 Jan 2023. As a result, that's the earliest date this issue can be addressed.

@cnunciato cnunciato mentioned this issue Jan 18, 2023
Merged
@aniravi24
Copy link

This should be unblocked now, Pulumi has merged this in!

@RobbieMcKinstry
Copy link

Indeed, it's unblocked! 🎉

@danielrbradley danielrbradley mentioned this issue Jan 27, 2023
Merged
danielrbradley added a commit to pulumi/pulumi-azure-native that referenced this issue Jan 30, 2023
@danielrbradley
Upgrade action versions (#2204)
ed8c8eb 
This should fix the following warnings:

> Node.js 12 actions are deprecated. Please update the following actions
to use Node.js 16: actions/checkout@v2, actions/setup-go@v2,
pulumi/action-install-pulumi-cli@v2, actions/setup-node@v2,
actions/setup-python@v2, actions/upload-artifact@v2. For more
information see:
https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

> The `set-output` command is deprecated and will be disabled soon.
Please upgrade to using Environment Files. For more information see:
https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The only remaining warnings are being printed by the setup-pulumi
action. Pending issue:
- pulumi/setup-pulumi#36

This also fixes the schema comment upsert behaviour which removes the
repetative comments on PRs

Version changes:
- setup-dotnet v1 -> v3
- setup-go v2 -> v3
- setup-node v2 -> v3
- setup-python v2 -> v4
- checkout v2 -> v3
- pulumi/action-install-pulumi-cli@v2 -> pulumi/setup-pulumi@v2
- thollander/actions-comment-pull-request v1 -> v2
- actions/download-artifact v2 -> v3
-  actions/upload-artifact v2 -> v3
- aws-actions/configure-aws-credentials v1 -> v1-node16
@alexandre-girard-maif
Copy link

alexandre-girard-maif commented Feb 3, 2023 •
edited
Loading

Hello,
any news about this issue ?

Thanks Alexandre

@simenandre
Copy link
Contributor

AFAIK, the error should disappear when updating to v4. Let me know if there's still issues :)

@simenandre simenandre added the resolution/fixed This issue was fixed label Feb 4, 2023
@aniravi24
Copy link

aniravi24 commented Feb 4, 2023 •
edited
Loading

Sorry @cobraz , v4 of what? This GitHub action is on v2. I thought the resolution for this issue is merging this PR and making sure this action is updated.

I might be missing something, but I don't think this issue is resolved yet.

@simenandre
Copy link
Contributor

You are right! I got mixed up with the pulumi/actions.

@simenandre simenandre reopened this Feb 4, 2023
@simenandre simenandre removed the resolution/fixed This issue was fixed label Feb 4, 2023
@andriiholubenko
Copy link

Hi, do you have any updates?

@RobbieMcKinstry
Copy link

Hi @andriiholubenko , not at this time, no. We're currently pulled in other directions. I expect I can find time this quarter, but I can't give any better estimates than that currently. I'm sorry, I wish I had a better answer for you.

@joeduffy
Copy link
Member

@abhinav, given #35 (comment), is this issue still relevant? It says that setup-pulumi is deprecated?

@abhinav abhinav added the resolution/wont-fix This issue won't be fixed label May 30, 2023
@abhinav
Copy link
Contributor

abhinav commented May 30, 2023

@joeduffy Yeah, good call. This issue is no longer relevant since #35 (comment).

Folks, as mentioned in #35 (comment), please switch to pulumi/actions with the following single line change:

BeforeAfter
 
- name: Install pulumi
  uses: pulumi/setup-pulumi@v2
- name: Install pulumi
  uses: pulumi/setup-pulumi@v2
  with:
    pulumi-version: 3.3.0
 
- name: Install pulumi
  uses: pulumi/actions@v4
- name: Install pulumi
  uses: pulumi/actions@v4
  with:
    pulumi-version: 3.3.0

Thanks!

Closing this issue as not planned.

@abhinav abhinav closed this as completed May 30, 2023
@RobbieMcKinstry RobbieMcKinstry pinned this issue May 31, 2023
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Some behavior is incorrect or out of spec resolution/wont-fix This issue won't be fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@abhinav @simenandre @joeduffy @RobbieMcKinstry @aniravi24 @ianschmitz @Zaid-Ajaj @alexandre-girard-maif @andriiholubenko