Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

devcontainer not working. Linked Repository archived 2024-12-12 #103

Closed
picpromusic opened this issue Dec 28, 2024 · 1 comment · May be fixed by #104
Closed

devcontainer not working. Linked Repository archived 2024-12-12 #103

picpromusic opened this issue Dec 28, 2024 · 1 comment · May be fixed by #104
Assignees
@iwahbe
Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed

Comments

@picpromusic
Copy link

picpromusic commented Dec 28, 2024 •
edited
Loading

What happened?

If i try to build a new provider with this template using the provided devcontainer (1 year old) it does not work.
The linked repository for the devcontainer definition is archived 2024-12-12 and it seems to contain a recursive definition of the docker-images for ghcr.io/pulumi/devcontainer:extra.

It doesn't seem to be an easy fix. Maybe the archive of https://github.com/pulumi/devcontainer is another sign that this functionality is broken.

It would be best to repair it. But if not possible it would be better to delete the files and hints in the README and create a feature-request.

Example

#git clone
#start devcontainer
#go version prints 1.20 which is to old
or start
make build install

Output of pulumi about

none

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).
@picpromusic picpromusic added kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team labels Dec 28, 2024
@picpromusic picpromusic mentioned this issue Dec 28, 2024
Open
@mjeffryes
Copy link
Member

Yes, unfortunately the devcontainer support has not been maintained. We're in process on an update to this boilerplate to pick up our latest workflows and tools. I'll ping this ticket when that rolls out.

@mjeffryes mjeffryes removed the needs-triage Needs attention from the triage team label Jan 23, 2025
iwahbe added a commit that referenced this issue Jan 31, 2025
@iwahbe
Remove Dev Containers
cf355d6 
We neither use nor maintain our dev container infrastructure. We should not recommend it
to new provider authors. If an org is already using dev containers, they can always add
their own to their provider. They will be more qualified to maintain it then we are.

Related: #104
Fixes #103
@iwahbe iwahbe closed this as completed in 5104399 Jan 31, 2025
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iwahbe iwahbe

Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

POC: Simplified Devcontainer that seems to work 2024-12 picpromusic/pulumi-provider-boilerplate
4 participants
@picpromusic @mjeffryes @iwahbe @pulumi-bot