Skip to content

Commit 128cb32

Browse files
authored
Merge pull request #1138 from pulp/patchback/backports/3.26/4020a8734b5d00075ac06dfb97346ff8eeefe2e3/pr-1136
[PR #1136/4020a873 backport][3.26] Fix syncing with non-https URL
2 parents 5593cc5 + 145983a commit 128cb32

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

CHANGES/+non-https-syncs.bugfix

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Fixed sync issue where non https URLs were not allowed.

pulp_python/app/tasks/sync.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,6 @@ def create_bandersnatch_config(remote):
6565
config = BandersnatchConfig()
6666
config["mirror"]["master"] = remote.url
6767
config["mirror"]["workers"] = str(remote.download_concurrency)
68-
config["mirror"]["allow_non_https"] = "true"
6968
if not config.has_section("plugins"):
7069
config.add_section("plugins")
7170
config["plugins"]["enabled"] = "blocklist_release\n"
@@ -120,7 +119,7 @@ async def run(self):
120119
if not isinstance(downloader, HttpDownloader):
121120
raise ValueError("Only HTTP(S) is supported for python syncing")
122121

123-
async with Master(url) as master:
122+
async with Master(url, allow_non_https=True) as master:
124123
# Replace the session with the remote's downloader session
125124
old_session = master.session
126125
master.session = downloader.session

0 commit comments

Comments
 (0)